Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken move anims in tests #3398

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix broken move anims in tests #3398

merged 1 commit into from
Oct 11, 2023

Conversation

DizzyEggg
Copy link
Collaborator

AI battle tests use too much heap, so I put ai log lines in EWRAM outside heap.

@AsparagusEduardo AsparagusEduardo merged commit 4033260 into rh-hideout:upcoming Oct 11, 2023
1 check passed
@mrgriffin mrgriffin mentioned this pull request Oct 13, 2023
Merged
DizzyEggg pushed a commit that referenced this pull request Oct 13, 2023
@mrgriffin
Move battle tests off the heap (#3413)
cbdba65 
* Catch OOM in tests

* Alias gBattleTestRunnerState with sBackupMapData

Reverts #3398 "Fix Broken Move Anims in Tests" which moved the AI logs
to statically-allocated EWRAM_DATA instead of being part of
gBattleTestRunnerState.
@DizzyEggg DizzyEggg deleted the ai_heap branch June 23, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DizzyEggg @AsparagusEduardo